[Webkit-unassigned] [Bug 71370] webkitdirs.pm: add getArchitecture implementation for autotools ports

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 9 08:41:27 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=71370


Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #114228|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #7 from Xan Lopez <xan.lopez at gmail.com>  2011-11-09 08:41:27 PST ---
(From update of attachment 114228)
View in context: https://bugs.webkit.org/attachment.cgi?id=114228&action=review

> Tools/Scripts/webkitdirs.pm:254
> +            # Fall back to output of `arch', if it is present.

Ultra nitpick, you don't really have further fallbacks, so I guess the "if it is present" is a bit misleading. You'll use that or fail in some way I suppose. Anyway, this looks OK to me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list