[Webkit-unassigned] [Bug 71718] Apparent threading bug causes intermittent segfaults

Wed Nov 9 08:20:42 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=71718

Andrew Wason <rectalogic at rectalogic.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #114287|                            |review?, commit-queue?
               Flag|                            |

--- Comment #3 from Andrew Wason <rectalogic at rectalogic.com>  2011-11-09 08:20:42 PST ---
Created an attachment (id=114287)
 --> (https://bugs.webkit.org/attachment.cgi?id=114287&action=review)
fix for static local race condition

This fixes the problem shown in the valgrind log. It allocates the threadMapMutex() on the stack so it's destructor doesn't run at process shutdown while outstanding WorkerThreads are still accessing it.

I did the same thing with threadMap() since it has a similar race condition. Also I initialize threadMap in initializeThreading() to avoid another race condition initializing it.

This patch seems to fix the problem evident in the valgrind log, but there are remaining problems that can still cause a crash when using WebWorkers. I will attach a helgrind log with more information shortly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.