[Webkit-unassigned] [Bug 71554] [Qt] 4 Layout test fail due to network error constant values clash with WebkitError enum values in FrameloaderclientQt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 9 05:20:08 PST 2011


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #114238|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |

--- Comment #10 from Simon Hausmann <hausmann at webkit.org>  2011-11-09 05:20:08 PST ---
(From update of attachment 114238)
The patch looks good (the right fix), but I'd prefer to replace the use of DEFINE_STATIC_LOCAL with a straight comparision of the domains as string literals.

The effort of unifying the string literals of the domains to a central place can be a separate patch.

So r- for the DEFINE_STATIC_LOCAL, but otherwise I really appreciate that you're fixing this rather nasty issue that is hard to find!

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list