[Webkit-unassigned] [Bug 70897] Use a simple page client/controller for user consent in getUserMedia()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70897





--- Comment #13 from Tommy Widenflycht <tommyw at google.com>  2011-11-09 02:23:49 PST ---
(From update of attachment 114178)
View in context: https://bugs.webkit.org/attachment.cgi?id=114178&action=review

> Source/WebCore/mediastream/UserMediaController.cpp:53
> +        m_client->userMediaControllerDestroyed();

At this point have all outstanding requests been cancelled? Would be best, I think, to do so.

>> Source/WebCore/mediastream/UserMediaRequest.cpp:78
>> +    for (size_t i = 0; i < optionsList.size(); i++) {
> 
> ++i

FYI: This means that you should change your i++ to ++i. A prefix operator is generally much better than a postfix one.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.