[Webkit-unassigned] [Bug 71792] Internals.markerRangeForNode should be able to take markers by specifying a marker type.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71792


MORITA Hajime <morrita at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #114211|review?                     |review-
               Flag|                            |




--- Comment #8 from MORITA Hajime <morrita at google.com>  2011-11-08 23:51:34 PST ---
(From update of attachment 114211)
View in context: https://bugs.webkit.org/attachment.cgi?id=114211&action=review

> Source/WebCore/testing/Internals.cpp:87
> +    

Could you propagate error to the caller and throw an exception for this?
Ignoring error here will make the troubleshooting hard.

Also, I want some way to specify "all". An empty string would be sufficient.

> LayoutTests/ChangeLog:10
> +        * platform/chromium/test_expectations.txt: Skipped chromium tests.

Could you add skip entries for other ports?
I guess almost all other port uses test_expectations.txt. Only Apple windows port uses Skipped file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.