[Webkit-unassigned] [Bug 71510] [Microdata] LayoutTests/fast/dom/MicroData/itemid-attribute-test.html assertion failure in Element::getURLAttribute()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71510





--- Comment #7 from Arko Saha <nghq36 at motorola.com>  2011-11-08 23:31:16 PST ---
(In reply to comment #6)
> (From update of attachment 113792 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=113792&action=review
> 
> > Source/WebCore/html/HTMLElement.cpp:1004
> > +bool HTMLElement::isURLAttribute(Attribute* attribute) const
> > +{
> > +#if ENABLE(MICRODATA)
> > +    return attribute->name() == itemidAttr;
> > +#else
> > +    return false;
> > +#endif
> > +}
> 
> This will fail to compile on platforms where we have MICRODATA off and we have unused argument warnings on.

Done.

> > Source/WebCore/html/HTMLElement.h:79
> > +    virtual bool isURLAttribute(Attribute*) const;
> 
> This should be protected, not public.

Done.

> > Source/WebCore/html/HTMLInputElement.cpp:1295
> > +    return (attr->name() == srcAttr || attr->name() == formactionAttr || HTMLTextFormControlElement::isURLAttribute(attr));
> 
> Should remove the unneeded parentheses here.

Done.

> > Source/WebCore/html/HTMLObjectElement.cpp:387
> > +    return (attr->name() == dataAttr || (attr->name() == usemapAttr && attr->value().string()[0] != '#') || HTMLPlugInImageElement::isURLAttribute(attr));
> 
> Should remove the unneeded parentheses here.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.