[Webkit-unassigned] [Bug 71128] Select multiple options with mouse drag in Select element.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71128





--- Comment #24 from Rakesh <rakesh.kn at motorola.com>  2011-11-08 11:30:31 PST ---
(In reply to comment #23)
> (From update of attachment 114121 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=114121&action=review
> 
> > Source/WebCore/page/EventHandler.cpp:567
> > +        if (!(targetNode->parentNode() && targetNode->parentNode()->renderer() && targetNode->parentNode()->renderer()->isListBox()))
> > +            return false;
> > +        isListBox = true;
> 
> Hm... on my second thought it's probably cleaner to keep the pointer to targetNode->parentNode()->renderer() because you're calling it again in line 580.

Ya, can we bring the RenderObject* renderer = targetNode->renderer(); up so that we can avoid even targetNode->renderer() twice but only thing we may be bringing out a if scoped variable? That will even avoid an extra local variable

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.