[Webkit-unassigned] [Bug 71554] [Qt] 4 Layout test fail due to network error constant values clash with WebkitError enum values in FrameloaderclientQt

Tue Nov 8 10:37:10 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=71554

--- Comment #8 from Jesus Sanchez-Palencia <jesus at webkit.org>  2011-11-08 10:37:10 PST ---
(In reply to comment #6)
> > Does that seem reasonable ???
> 
> Yes, I think that's the correct fix.

+1 as it goes along with the current WK2 implementation.

On a side note, the only thing that bothers me is using this strings for error domains (i.e. "WebKit", "HTTP", etc) everywhere. Perhaps we should concentrate static functions somewhere together with the error code enums and use them in both WK1 and WK2 implementations, pretty much everywhere we create or check a ResourceError. But this is another discussion and another patch, not needed for this bug.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.