[Webkit-unassigned] [Bug 60605] [NRWT] Reftests should run even when pixel tests are disabled.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60605





--- Comment #15 from Ojan Vafai <ojan at chromium.org>  2011-11-08 08:40:29 PST ---
(In reply to comment #14)
> (In reply to comment #13)
> > If '-p' is given, we run *traditional* pixel tests and run also reftests.
> > If '-p' is not given, we don't run *traditional* pixel tests, but reftests should be run.
> > Reftests should be run in both cases.
> 
> Right.

Yup.

> > Maybe we should have additional cmd line option, e.g. '--run-reftests', but it should be 'on' by default, shouldn't we?
> 
> Agreed.
> 
> But I think it's worth hearing what other ports' contributors feel about doing png comparison vs. render tree dump comparison.

I think my email to webkit-dev about turning reftests on by default was sufficient. Everyone who chimed in supports doing it and noone objected. Is there a port your concerned about?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.