[Webkit-unassigned] [Bug 71128] Select multiple options with mouse drag in Select element.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71128


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #113337|review?                     |review-
               Flag|                            |




--- Comment #18 from Ryosuke Niwa <rniwa at webkit.org>  2011-11-07 23:09:08 PST ---
(From update of attachment 113337)
View in context: https://bugs.webkit.org/attachment.cgi?id=113337&action=review

> Source/WebCore/page/EventHandler.cpp:561
> +          || !(targetNode->renderer() || (targetNode->parentNode()->renderer() && targetNode->parentNode()->renderer()->isListBox())))

We should probably define a boolean here.

> Source/WebCore/page/EventHandler.cpp:573
> +        if (!renderer && targetNode->parentNode()->renderer()->isListBox())

To avoid repeating the condition here.

> LayoutTests/fast/forms/select-multiple-elements-with-mouse-drag.html:9
> +window.jsTestIsAsync = true;
> +
> +function test() {

This test doesn't need to be async. r- because of this.

> LayoutTests/fast/forms/select-multiple-elements-with-mouse-drag.html:20
> +        eventSender.mouseDown();
> +        eventSender.mouseMoveTo(x, y + (optionHeight * 3));

You probably need leapForward here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.