[Webkit-unassigned] [Bug 60605] [NRWT] Reftests should run even when pixel tests are disabled.

Mon Nov 7 22:17:57 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=60605

--- Comment #10 from Dirk Pranke <dpranke at chromium.org>  2011-11-07 22:17:57 PST ---
(In reply to comment #9)
> (In reply to comment #8)
> > I have always assumed that people don't run pixel tests because the pixel tests fail (the png's aren't correct), not that they were too slow. Hence, I support this change.
> 
> The last time I checked generating/comparing pixel tests were significantly slower than generating/comparing render tree dumps.

Yes, I am sure that this is true.

> 
> > It is possible that they were slower with ORWT, but given NRWT running with more than one thread, this would seem like not much of an issue.
> 
> Possible. It'll be nice to get numbers.

I think you're missing my point; I've never heard anyone say that they skip pixel tests w/ NRWT because they're too slow. Possibly this was true with ORWT, but given how much faster NRWT can be than ORWT, I don't think it matters all that much. If someone is worried about cycle time, there are lots of things we can do to improve the cycle time; we should not let that be an argument against getting people to write reftests instead of pixel tests, given the other benefits that they will bring.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.