[Webkit-unassigned] [Bug 71595] [chromium] Add draw-time scale delta to compositor thread

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 7 21:43:45 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=71595





--- Comment #13 from Alexandre Elias <aelias at chromium.org>  2011-11-07 21:43:45 PST ---
OK, all style nits applied.  I also synced up the client.  Note that this change conflicted with enne's clipping fix because I removed m_maxScrollPosition from the non-impl side.  I needed to introduce a "m_scrollable" boolean to allow the root layer to be discovered, and obtained the content bounds from a child layer.

(In reply to comment #9)
> (From update of attachment 113803 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=113803&action=review
> 
> > Source/WebCore/platform/graphics/chromium/LayerChromium.cpp:214
> > +    if (firstResize || m_pageScaleDirty)
> 
> Can you explain why the full-layer invalidation needs to happen in setBounds?
> 
> Also, I'm a little confused why you need to do this invalidation yourself.  Shouldn't WebKit invalidate everything when the scale changes? And, if it somehow doesn't, why not just call LayerChromium::setNeedsDisplay() instead of calling deviceOrPageScaleFactorChanged?

It's because the invalidation is clipped to the bounds, and the bounds are multiplied by the scale, so we need to defer it until after they're changed.  There may be a cleaner way to do this, but it doesn't seem like too bad of a hack for now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list