[Webkit-unassigned] [Bug 60605] [NRWT] Reftests should run even when pixel tests are disabled.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 7 20:38:06 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=60605





--- Comment #8 from Dirk Pranke <dpranke at chromium.org>  2011-11-07 20:38:06 PST ---
(In reply to comment #7)
> I'm concerned that running reftests as implemented now might be as slow as running pixel tests. If that were the case, then always enabling reftests defeats the point of not running pixel tests (fast cycle time).
> 
> Do we have data to suggest otherwise? (i.e. running reftests is as fast as running render tree dump tests) Or are we going to compare render tree dumps when -p is not passed?

I have always assumed that people don't run pixel tests because the pixel tests fail (the png's aren't correct), not that they were too slow. Hence, I support this change.

It is possible that they were slower with ORWT, but given NRWT running with more than one thread, this would seem like not much of an issue.

That said, I assume running reftests are significantly slower than either pixel tests or text-only tests, since we have to do double the work.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list