[Webkit-unassigned] [Bug 71746] DFG code base should allow for classes not related to DFG::JITCompiler to use DFG idioms

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 7 16:30:19 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=71746


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2011-11-07 16:30:20 PST ---
Attachment 113951 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/dfg/DFGAssemblyHelpers.h:35:  Alphabetical sorting problem.  [build/include_order] [4]
Source/JavaScriptCore/dfg/DFGAssemblyHelpers.h:171:  Missing space inside { }.  [whitespace/braces] [5]
Source/JavaScriptCore/dfg/DFGAssemblyHelpers.h:172:  Missing space inside { }.  [whitespace/braces] [5]
Source/JavaScriptCore/dfg/DFGAssemblyHelpers.h:173:  Missing space inside { }.  [whitespace/braces] [5]
Source/JavaScriptCore/dfg/DFGAssemblyHelpers.h:174:  Missing space inside { }.  [whitespace/braces] [5]
Source/JavaScriptCore/dfg/DFGAssemblyHelpers.h:175:  Missing space inside { }.  [whitespace/braces] [5]
Source/JavaScriptCore/dfg/DFGAssemblyHelpers.h:224:  The parameter name "flag" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 7 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list