[Webkit-unassigned] [Bug 71660] Remove [CustomGetter] IDL for HTMLAudioElementConstructor of V8.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 7 14:07:38 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=71660





--- Comment #5 from Kentaro Hara <haraken at chromium.org>  2011-11-07 14:07:38 PST ---
(In reply to comment #4)
> How does Image and HTMLImageElement work?

Image and HTMLImageElement, and Option and HTMLOptionElement are working in a similar way as I am trying to do for Audio and HTMLAudioElement in this patch, although they are still achieving it using a custom getter (I am going to remove their cutom getters in follow-up patches).

- "attribute HTMLImageElementConstructor HTMLImageElement" in DOMWindow.idl generates the code to set the wrapper type of window.HTMLImageElement to V8HTMLImageElement. Specifically, the generated code in V8DOMWindow.cpp is as follows:

{"HTMLImageElement", DOMWindowInternal::DOMWindowConstructorGetter, 0, &V8HTMLImageElement::info, static_cast<v8::AccessControl>(v8::DEFAULT), static_cast<v8::PropertyAttribute>(v8::ReadOnly), 0 /* on instance */},

- "attribute [CustomGetter] HTMLImageElementConstructor Image" generates a code to call a custom getter that sets the wrapper type of window.Image to V8HTMLImageElementConstructor. Specifically, the custom getter written in V8DOMWindowCustom.cpp is as follows:

v8::Handle<v8::Value> V8DOMWindow::ImageAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
{
    DOMWindow* window = V8DOMWindow::toNative(info.Holder());
    return V8DOMWrapper::getConstructor(&V8HTMLImageElementConstructor::info, window);
}

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list