[Webkit-unassigned] [Bug 71660] Remove [CustomGetter] IDL for HTMLAudioElementConstructor of V8.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71660





--- Comment #3 from Kentaro Hara <haraken at chromium.org>  2011-11-07 13:25:46 PST ---
(In reply to comment #2)
> (From update of attachment 113844 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=113844&action=review
> 
> > Source/WebCore/page/DOMWindow.idl:630
> > -        attribute [CustomGetter, Conditional=VIDEO, EnabledAtRuntime] HTMLAudioElementConstructor Audio; // Usable with the new operator
> > +        attribute [JSCCustomGetter, Conditional=VIDEO, EnabledAtRuntime] HTMLAudioElementConstructorConstructor Audio; // Usable with the new operator
> 
> I don't fully understand why HTMLAudioElementConstructorConstructor is needed in place of HTMLAudioElementConstructor.  It seems like Audio is indeed just an HTMLAudioElementConstructor because calling "new Audio()" gives you an HTMLAudioElement.  Maybe this is something we should change in the code generator?

In my understanding...

- window.HTMLAudioElement and window.Audio are different things. In other words, they have different wrapper types (i.e. WebCore::BatchedAttribute::WrapperTypeInfo should be different). Currently, the wrapper type of window.HTMLAudioElement is implemented as class V8HTMLAudioElement, and the wrapper type of window.Audio is implemented as V8HTMLAudioElementConstructor.

- "attribute HTMLAudioElementConstructor HTMLAudioElement" in DOMWindow.idl indicates that the wrapper type of window.HTMLAudioElement is V8HTMLAudioElement.

- "attribute HTMLAudioElementConstructorConstructor Audio" in DOMWindow.idl indicates that the wrapper type of window.Audio is V8HTMLAudioElementConstructor.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.