[Webkit-unassigned] [Bug 69835] [GStreamer] WebAudio AudioDestination

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69835


Philippe Normand <pnormand at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pnormand at igalia.com




--- Comment #4 from Philippe Normand <pnormand at igalia.com>  2011-11-07 06:53:14 PST ---
(In reply to comment #3)
> Hi Sebastian, can you please have a look at this patch?

>From IRC:

<slomo_> philn-tp: you should check if wavparse and the other elements are available (gst_element_factory_create() returns non-NULL)

15:39:02 <slomo_> philn-tp: you should check if wavparse and the other elements are available (gst_element_factory_create() returns non-NULL)
15:40:14 <philn-tp> ah, right, the ones not in -core and -base at least
15:40:48 <slomo_> philn-tp: center and mono are not the same
15:41:42 <philn-tp> yeah, i know, go tell that to Chris :)
15:42:45 <philn-tp> slomo_: it's in AudioBus.h, line 48
15:43:54 <philn-tp> slomo_: i'll file a bug about that
15:44:03 <slomo_> philn-tp: why is this using a separate task for the srcpad?
15:45:20 <slomo_> philn-tp: other than that this looks good
15:45:37 <philn-tp> slomo_: hum, not sure to understand your question ;)
15:47:19 <slomo_> philn-tp: i don't understand why there is a GstTask :)
15:49:03 <philn-tp> slomo_: well I need to pull the data from AudioBus when needed, would you suggest some other way than a task?
15:50:14 <slomo_> philn-tp: oh i see... no, that's fine :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.