[Webkit-unassigned] [Bug 71595] [chromium] Add draw-time scale delta to compositor thread

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71595





--- Comment #6 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-11-05 15:01:52 PST ---
(From update of attachment 113742)
View in context: https://bugs.webkit.org/attachment.cgi?id=113742&action=review

> Source/WebKit/chromium/public/WebLayerTreeViewClient.h:44
> +    virtual void applyScrollAndScale(const WebSize&, float) = 0;

nit: please give the float parameter a name.  i think "scaleFactor" would work.
the WebSize parameter could probably also benefit from a name:  "scrollDelta"

> Source/WebKit/chromium/public/WebView.h:212
> +    virtual void setScaleLimits(float minScale, float maxScale) = 0;

since this impacts "PageScaleFactor", it seems like the function name should include
that term.  how about calling this function setPageScaleFactorLimits?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.