[Webkit-unassigned] [Bug 70484] [WK2] add flag to only check pixel results if png files exist

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70484





--- Comment #13 from Dirk Pranke <dpranke at chromium.org>  2011-11-04 17:41:22 PST ---
(From update of attachment 112825)
View in context: https://bugs.webkit.org/attachment.cgi?id=112825&action=review

>> Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:113
>> +        if self._port.driver_name() == "WebKitTestRunner" and self._port.get_option('skip_pixel_test_if_no_baseline') and self._port.get_option('pixel_tests'):
> 
> Can you use self._options.skip_pixel_test_if_no_baseline and self._options.pixel_tests instead?

I think self._options is shared between this object and the enclosing worker object, meaning if you set this to False here, all subsequent tests run in that worker will also not use pixel tests. I'm guessing you don't want that.

>> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:86
>> +        if options.skip_pixel_test_if_no_baseline and not (port.driver_name() == "WebKitTestRunner"):
> 
> Nit: != seems a little clearer than not (...)

Why is this change specific to WebKitTestRunner ? Why wouldn't we want to support this in DRT as well?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.