[Webkit-unassigned] [Bug 71190] Document.importNode's 'deep' argument should default to true

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71190





--- Comment #15 from Adam Barth <abarth at webkit.org>  2011-11-04 17:29:33 PST ---
> Sorry Adam, I guess I couldn't get your point. Did you wanted something like this new patch..?

The IDL files should say [Optional] without any attribute value and there should be no custom bindings for this method.  In you first patch you did the former but not the latter.  In the second patch, you did the former but not the former.

We eventually want to get down to only using [Optional] without any values anywhere.  Adding more values moves us away from that goal.  Also, all the custom code in the bindings is full of bugs.  We don't want to add any more custom code than absolutely necessary.

I'm surprised this doesn't just work out of the box for you, but maybe there's a bug in the code generator script that's causing problems for you.  You can also remove the value of the Optional attribute for importedNode if that's what's causing you trouble.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.