[Webkit-unassigned] [Bug 71465] [GTK][DRT] implement FrameLoaderClient::didDetectXSS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71465


Zan Dobersek <zandobersek at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zandobersek at gmail.com




--- Comment #1 from Zan Dobersek <zandobersek at gmail.com>  2011-11-04 13:36:19 PST ---
Looking around this test, I've seen that FrameLoaderClient::didDetectXSS is called, so the line containing 'didDetectXSS' should be written into output, but the problem occurs when transporting this information to DumpRenderTree.

When bringing up layout tests support for Clutter's port of WebKit, I created a DRTSupportGObject singleton structure[1][1.1]. Its purpose is to hold various signals that could easily be emitted from WebKit library[2] and to which it would be simple to connect[3] and then output the gathered information[4].

I propose the same kind of approach to be utilized in the Gtk port. Of course, in a different bug.


[1] https://gitorious.org/webkit-clutter/webkit-clutter/blobs/master/Source/WebKit/gobject/WebCoreSupport/DumpRenderTreeSupportGObject.cpp
[1.1] https://gitorious.org/webkit-clutter/webkit-clutter/blobs/master/Source/WebKit/clutter/WebCoreSupport/DumpRenderTreeSupportClutter.cpp#line85
[2] https://gitorious.org/webkit-clutter/webkit-clutter/blobs/master/Source/WebKit/gobject/WebCoreSupport/FrameLoaderClientGObject.cpp#line803
[3] https://gitorious.org/webkit-clutter/webkit-clutter/blobs/master/Tools/DumpRenderTree/clutter/DumpRenderTree.cpp#line799
[4] https://gitorious.org/webkit-clutter/webkit-clutter/blobs/master/Tools/DumpRenderTree/clutter/DumpRenderTree.cpp#line732

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.