[Webkit-unassigned] [Bug 70484] [WK2] Enable pixel test on WK2 if expected.png exists

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70484


Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #112825|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #12 from Tony Chang <tony at chromium.org>  2011-11-04 10:12:49 PST ---
(From update of attachment 112825)
View in context: https://bugs.webkit.org/attachment.cgi?id=112825&action=review

Can you write some python unit tests for this flag?

> Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:113
> +        if self._port.driver_name() == "WebKitTestRunner" and self._port.get_option('skip_pixel_test_if_no_baseline') and self._port.get_option('pixel_tests'):

Can you use self._options.skip_pixel_test_if_no_baseline and self._options.pixel_tests instead?

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:86
> +        if options.skip_pixel_test_if_no_baseline and not (port.driver_name() == "WebKitTestRunner"):

Nit: != seems a little clearer than not (...)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.