[Webkit-unassigned] [Bug 70765] Default <select multiple> expands up to 10 items instead of showing 4

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70765


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #113633|review?                     |review+
               Flag|                            |




--- Comment #14 from Darin Adler <darin at apple.com>  2011-11-04 09:59:11 PST ---
(From update of attachment 113633)
View in context: https://bugs.webkit.org/attachment.cgi?id=113633&action=review

> LayoutTests/fast/forms/select-clientheight-with-multiple-attr-expected.txt:6
> +PASS clientHeight('sel2') is clientHeight('sel1')
> +PASS getElemById('sel2').setAttribute('size', '5'); clientHeight('sel2') > clientHeight('sel1') is true
> +PASS clientHeight('sel3') is clientHeight('sel1')
> +PASS getElemById('sel3').setAttribute('size', '2'); clientHeight('sel3') is clientHeight('sel1')

Good approach on this test now.

I think we should test more than just the fact that the height is larger when there are more items. We can compare to an exact multiple, and I think it would work fine on all platforms.

And, I think we should test a *lot* more than these two cases. We want to cover all the edge cases. Really giant sizes, really small sizes, missing size attribute, specified size attribute, size attribute that is a number but has garbage digits after it, size attribute that is the empty string.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.