[Webkit-unassigned] [Bug 71478] Fix up chromium API for creating events, initializing message events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71478





--- Comment #6 from Dave Michael <dmichael at chromium.org>  2011-11-04 07:50:19 PST ---
(In reply to comment #4)
> (From update of attachment 113506 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=113506&action=review
> 
> > Source/WebKit/chromium/src/WebDOMMessageEvent.cpp:58
> > +        static_cast<const WebFrameImpl*>(sourceFrame)->frame()->domWindow();
> 
> don't you need to assign domWindow() to 'window' ?
Definitely. Nice catch. Speaking of, is there a good place to add a unit test for this? Should I do that, or does the ui_test in chromium (which doesn't cover this code path right now) suffice?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.