[Webkit-unassigned] [Bug 71352] [EFL] Port tiled backing store

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71352





--- Comment #10 from Raphael Kubo da Costa <kubo at profusion.mobi>  2011-11-04 07:48:39 PST ---
(From update of attachment 113631)
View in context: https://bugs.webkit.org/attachment.cgi?id=113631&action=review

I'd use "backing_store" instead of "backingstore" in the function names as they are separate words.

I'd also like to know how this is going to interact with the tiled backing store implementation in ewk (the API added to ewk_view looks weird if one is using it instead of the single backing store, to start with).

> ChangeLog:3
> +        [EFL] Port tiled backing store

This sounds a bit misleading: the EFL port already has a tiled backing store; I'd rephrase it as "Make it possible to use WebCore's tiled backing store in EFL" or something like that.

> Source/WebCore/CMakeListsEfl.txt:106
> +  IF (WTF_USE_TILED_BACKING_STORE)

Isn't it always on?

> Source/WebCore/CMakeListsEfl.txt:150
> +IF (WTF_USE_TILED_BACKING_STORE)

Ditto.

> Source/WebKit/efl/ChangeLog:8
> +        Ported tiled backing store to EFL WebKit port.

Same thing about the misleading phrase.

> Source/WebKit/efl/ChangeLog:14
> +        Major changes:
> +        - Added new functions to ChromeClientEfl
> +        - Added new functions to ewk_view
> +        - From ewk_view_single calls
> +          ewk_view_setting_tiled_backingstore_enable_set to enable/disable
> +          use of tiled backing store

This is already evident from the lines below; it'd be good to know the motivation and how this interacts with the tiled backing store implementation in ewk.

> Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:67
> +#if USE(TILED_BACKING_STORE)

Isn't it always on?

> Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:441
> +    WebCore::FloatRect rect = ewk_view_page_rect_get(m_view);
> +    Evas_Object* frame = ewk_view_frame_main_get(m_view);

These can be const.

> Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:516
> +    Eina_Rectangle area;
> +    EINA_RECTANGLE_SET(&area, updateRect.x(), updateRect.y(), updateRect.width(), updateRect.height());
> +
> +    ewk_view_backingstore_invalidate(m_view, &area);

This is a private function, you could just pass the IntRect to tehe function.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.