[Webkit-unassigned] [Bug 71479] [chromium] Beef up FakeCCThread for easier compositor testing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 4 04:10:46 PDT 2011


--- Comment #8 from Iain Merrick <husky at google.com>  2011-11-04 04:10:46 PST ---
(From update of attachment 113520)
View in context: https://bugs.webkit.org/attachment.cgi?id=113520&action=review

>> Source/WebKit/chromium/tests/CCDelayBasedTimeSourceTest.cpp:-107
>> -        long long delay = thread.pendingDelay();
> I'm really confused here, setTime causes the message loop to tick? I don't like that at all, it might make simpler code but its very hard to reason about what's going on -- much less set a breakpoint. Manipulating the fake thread's state should not run tasks.

I'm convinced that this approach is a win for more complex tests, but setTime() is definitely a misleading name.

How about if it were called runTasksUntilTime()?

>> Source/WebKit/chromium/tests/CCDelayBasedTimeSourceTest.cpp:122
>> +    thread.setTime(3000);
> why set the time here?

Just threw it in because it was easy, but I guess it doesn't give any extra coverage. :)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list