[Webkit-unassigned] [Bug 19079] Send the submissions character encoding in hidden _charset_ field

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19079


Vineet Chaudhary (vineetc) <rgf748 at motorola.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #113138|0                           |1
        is obsolete|                            |




--- Comment #9 from Vineet Chaudhary (vineetc) <rgf748 at motorola.com>  2011-11-04 02:42:08 PST ---
Created an attachment (id=113639)
 --> (https://bugs.webkit.org/attachment.cgi?id=113639&action=review)
Updated Patch

Updated patch

> * According to the specification, we should set the character encoding only if the hidden input has no value attribute.
As the behavior of IE9, Firefox 7, and Opera 11.51. All of them didn't care about the existence of value attribute I think we can also have same behavior. 
// Let me know if we want different behavior.

> * I don't think we should update HTMLInputELement::value.  How does IE work?
> * It's dangerous to use setValueForUser(), which dispatches an event and execute JavaScript code, which might update the associated element list.

Done : As none of the browser changes the HTMLInputELement::value. Thanks for pointing out!

> > LayoutTests/ChangeLog:14
> > +        * http/tests/misc/char_encoding_in_hidden_charset_field_01-expected.txt: Added.
> > +        * http/tests/misc/char_encoding_in_hidden_charset_field_01.html: Added. For Default Encoding.
> 
> We usually use '-' to concatenate words, not '_'.
Done:

> We should have tests for Chinese/Japanese encodings such as Big5, Shift_JIS, EUC-JP, ISO-2022-JP.  This feature is important in these countries.
Done: Added few more test cases for encodings Big5, Shift_JIS, EUC-JP, ISO-2022-JP.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.