[Webkit-unassigned] [Bug 70407] [TexMap][QT] PageClientQt should skip redundant sync requests during Accelerated Composition.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 3 13:41:10 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=70407


Noam Rosenthal <noam.rosenthal at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #111585|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #2 from Noam Rosenthal <noam.rosenthal at nokia.com>  2011-11-03 13:41:10 PST ---
(From update of attachment 111585)
View in context: https://bugs.webkit.org/attachment.cgi?id=111585&action=review

I don't understand the problem, and the patch is either way incorrect.
syncLayers should turn the shoulsSync flag off, as by that point we have already synced. There might be an issue with animations, in that case setting the flag should only occur inside the if loop in line 254.

> Source/WebKit/qt/ChangeLog:8
> +        PageClientQt should receives the sync request after actual TexMap drawing.

This sentence does not make sense in English.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list