[Webkit-unassigned] [Bug 71479] [chromium] Beef up FakeCCThread for easier compositor testing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71479





--- Comment #7 from Nat Duca <nduca at chromium.org>  2011-11-03 12:26:41 PST ---
(From update of attachment 113520)
View in context: https://bugs.webkit.org/attachment.cgi?id=113520&action=review

> Source/WebKit/chromium/tests/CCDelayBasedTimeSourceTest.cpp:41
> +TEST(CCDelayBasedTimeSourceTest, TaskPostedAndtickCalled)

uppercase t

> Source/WebKit/chromium/tests/CCDelayBasedTimeSourceTest.cpp:-92
> -    EXPECT_FALSE(thread.hasPendingTask());

why remove this?

> Source/WebKit/chromium/tests/CCDelayBasedTimeSourceTest.cpp:-107
> -    for (int i = 0; i < numIterations; ++i) {
> -        long long delay = thread.pendingDelay();

I'm really confused here, setTime causes the message loop to tick? I don't like that at all, it might make simpler code but its very hard to reason about what's going on -- much less set a breakpoint. Manipulating the fake thread's state should not run tasks.

> Source/WebKit/chromium/tests/CCDelayBasedTimeSourceTest.cpp:122
> +    thread.setTime(3000);

why set the time here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.