[Webkit-unassigned] [Bug 71493] New: __defineGetter__/__defineSetter__ should be implemented in terms of JSObject::defineOwnProperty

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 3 11:50:14 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=71493

           Summary: __defineGetter__/__defineSetter__ should be
                    implemented in terms of JSObject::defineOwnProperty
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: sam at webkit.org


Right now, __defineGetter__/__defineSetter__ are implemented by calling virtual (actually static on the MethodTable) JSObject::defineGetter/defineSetter, but we could implement it in terms of JSObject::defineOwnProperty and remove two virtual functions from the MethodTable.  This would also be more forward looking, by implementing the legacy __defineGetter__/__defineSetter__ in terms of the now specified defineOwnProperty.

If we do this, we need to make sure we continue block the specific uses of __defineGetter__/__defineSetter__ in JSLocation and JSDOMWindow.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list