[Webkit-unassigned] [Bug 71456] [PATCH] Move duplicates of SYMBOL_STRING* macros to the single location

Thu Nov 3 11:09:44 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=71456

Gavin Barraclough <barraclough at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #113454|review?                     |review-
               Flag|                            |

--- Comment #2 from Gavin Barraclough <barraclough at apple.com>  2011-11-03 11:09:44 PST ---
(From update of attachment 113454)
I have a local change to carve out of a big patch that would do something similar to this, so agree in principal, and would be happy to see something like this land - but I'm not sure that Platform.h is really the right place for things like this to go.

After discussing with Sam, I was going to add a new wtf/InlineASM.h file for helper macros like this, but am open to better suggestions.  I'm going to clear r- for now, so that no-one is too trigger happy on the r+ while we discuss this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.