[Webkit-unassigned] [Bug 66477] [GTK] Html5 Notification, testing facilities

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66477





--- Comment #7 from Martin Robinson <mrobinson at webkit.org>  2011-11-03 10:36:09 PST ---
(From update of attachment 112686)
View in context: https://bugs.webkit.org/attachment.cgi?id=112686&action=review

> Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:1028
> +void DumpRenderTreeSupportGtk::simulateDesktopNotificationClick(char* title)
> +{
> +#if ENABLE(NOTIFICATIONS)
> +    GList* match = g_list_find_custom(s_notifications, title, (GCompareFunc)matchNotificationByTitle);
> +
> +    if (!match)
> +        return;
> +
> +    WebKitWebNotification* notification = WEBKIT_WEB_NOTIFICATION(match->data);
> +    webkit_web_notification_clicked(notification);
> +#endif
> +}

I think you could make this the only method in DumpRenderTreeSupport.  It could take the WebKitWebNotification as the argument.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.