[Webkit-unassigned] [Bug 66650] [Qt] Flash in a QGraphicsWebView using OpenGL is slow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66650


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #113167|review?                     |review-
               Flag|                            |




--- Comment #19 from Simon Hausmann <hausmann at webkit.org>  2011-11-03 09:37:46 PST ---
(From update of attachment 113167)
I'm sorry, I'm giving this an r-. At the very least because the ChangeLog doesn't make much sense
by saying that "Plugins are now drawn on a QPixmap instead of on a X11 Pixmap when the OpenGL backend is used".

X11 windowless plugins can only be rendered onto X11 pixmaps (technically it's a general purpose X11 drawable, but a pixmap
by all means). The following line is responsible for passing the information _where_ the plugin should paint to:

    exposeEvent.drawable = qtDrawable.handle();

That means qtDrawable must be a QPixmap that is backed by an X11 pixmap.

This is the case with the current code and unless you're using the OpenGL graphics system, a regular QPixmap instance allocated
with Qt compiled for X11 will _also_ be backed by an x11 pixmap. So the statement "...draw onto QPixmap instead of on an X11 Pixmap" doesn't make sense because QPixmap is _also_ backed by an X11 pixmap, returned by handle().

If however the OpenGL graphics system is used, then QPixmaps will not be backed by X11 pixmaps and QPixmap::handle() will return 0. A 0
drawable is certainly not going to make the plugin paint.


So either I am missing something (in which case please elaborate in the ChangeLog) or the patch will not have any effect and certainly break plugin rendering when the OpenGL graphics system is used, because QPixmap::handle() will return 0 unless the QPixmap was constructed using QPixmap::fromX11Pixmap.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.