[Webkit-unassigned] [Bug 71466] [GTK] Add back/forward menus to MiniBrowser using WebKit2 GTK+ API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71466


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #113476|review?                     |review+
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2011-11-03 09:14:48 PST ---
(From update of attachment 113476)
View in context: https://bugs.webkit.org/attachment.cgi?id=113476&action=review

> Tools/MiniBrowser/gtk/BrowserWindow.c:101
> +        return 0;

0 -> NULL

> Tools/MiniBrowser/gtk/BrowserWindow.c:110
> +        GtkAction *action = gtk_action_new(uri, title, 0, 0);

This is C so the zeros should be NULL, I think.

> Tools/MiniBrowser/gtk/BrowserWindow.c:111
> +        g_object_set_data_full(G_OBJECT(action), "back-forward-list-item", g_object_ref(item), (GDestroyNotify)g_object_unref);

You might not need to cast GDestroyNotify here. Please check before landing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.