[Webkit-unassigned] [Bug 71350] Added TileCairo and TiledBackingStoreBackendCairo files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71350





--- Comment #5 from Tomasz Morawski <t.morawski at samsung.com>  2011-11-03 01:50:33 PST ---
Thanks for review. I will put a new version of patch soon.

> > Source/WebCore/platform/graphics/cairo/TiledBackingStoreBackendCairo.cpp:46
> > +static const unsigned checkerColor1 = 0xff555555;
> > +static const unsigned checkerColor2 = 0xffaaaaaa;
> 
> What colors are these?
I am sorry I don't know names of these colors (I am a men) but it are generally grey (light and dark). These colors are defined in TileQt also. May be the better idea will be to have one checker color definition for all port. 

> > Source/WebCore/platform/graphics/cairo/TiledBackingStoreBackendCairo.cpp:63
> > +            if (alternate)
> > +                setSourceRGBAFromColor(cr.get(), checkerColor1);
> > +            else
> > +                setSourceRGBAFromColor(cr.get(), checkerColor2);
> 
> I think it's much clearer to call cairo_set_source_rgba directly here!
Yes, it could be done. But if the above colors definition will stay the use of  
setSourceRGBAFromColor is simpler then cairo_set_source_rgba.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.