[Webkit-unassigned] [Bug 66295] [Meta] Support a reftest which follows CSS test format guidelines defined by CSS working group

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 2 19:34:06 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=66295





--- Comment #7 from Dirk Pranke <dpranke at chromium.org>  2011-11-02 19:34:06 PST ---
(In reply to comment #6)
> (In reply to comment #1)
> > If the reftest links are embedded in the file, presumably that means that we can't tell from the filename (and the -expected.html convention) that something is a reftest; this might complicate things a bit.
> 
> Why is this a problem?

The code in single_test_runner runs different code paths based on whether it's a ref test or not, and that branch is done before we run the test. So we'd either have to open the test file ourselves and figure out that it's a reftest (making things somewhat fragile because we'd have to duplicate the logic in DRT and incurring a perf hit), or restructure the code so that we get that info handed back from DRT (as Ojan suggests in comment #3, which *I think* is true, but I'm not 100% positive).

Note that we might want to duplicate the logic anyway in order for the MockDRT to work (I believe the MockDRT currently crashes on reftests).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list