[Webkit-unassigned] [Bug 70404] [EFL] Implement port layer of keygen element.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70404





--- Comment #20 from Raphael Kubo da Costa <kubo at profusion.mobi>  2011-11-02 18:09:39 PST ---
(In reply to comment #19)
> (In reply to comment #18)
> > It looks like part of the code is missing -- who is calling fetchPrivateKey(), for example? 
> 
> No one calls fetchPrivateKey() function now, because the specification of keygen is not define who use and how to use the private key.
> But I've made the function because the function is definitely needed to use the private key.

Could you give some use cases at least (which parts of WebCore or WebKit would need it, for example)? I'm asking because depending on the uses it might be better to store the data using another data structure (and the private key is being stored in plain memory, but I don't know what the other ports do in this regard, so I may be being too paranoid on this one).

> > And if you use a singleton as you do in getInstance(), who's going to destroy your object?
> 
> I know this is the reason why you've recommended me to use the macro.

This is not the reason why I've mentioned that macro. Even if you use your code without the DEFINE_STATIC_LOCAL change, you are creating an object on the heap but never deleting it, so the destructor will not be called.

> I'm still looking for how to use singletone pattern in WebKit.
> I need to use the design pattern, and I have not found that pattern in WebKit yet.

If by singleton you simply mean preventing users from having more than 1 instance of the class, then both your original patch and DEFINE_STATIC_LOCAL do that.

> > CMake already has FindOpenSSL.cmake, there's no need for this file.
> 
> Is it? As I know, there is no "FindOpenSSL.cmake" file under Source/cmake/.
> Could please let me know where the file is?

I mean CMake itself.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.