[Webkit-unassigned] [Bug 71412] Move LayoutTypes.h from rendering/ to platform/

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71412





--- Comment #6 from Darin Adler <darin at apple.com>  2011-11-02 16:22:55 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > What else besides ScrollableArea?
> 
> ScrollView and Scrollbar.
> 
> > I think it would not be helpful to have ScrollableArea use LayoutUnit if the callers using ScrollableArea are using LayoutUnit. If the callers are using LayoutUnit, then they must not be in the platform layer.
> 
> I'm not sure I'm following. Are you suggesting that we should keep it as ints for now and switch it over directly to fixed as a part of the big patch that switches from ints to fixed?

No. I think platform should not be built on top of the fractional system we invent for layout.

> Or are you suggesting that we keep the base classes defined in platform/ using ints but have the subclasses in rendering use layout types?

We can have scrolling machinery in platform that works without knowing that the thing its scrolling is using some different type for its internal layout. I don’t see why the scrolling machinery itself needs to deal with fractional pixels.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.