[Webkit-unassigned] [Bug 71416] New: Improve shouldThrow from js-test-pre.js

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71416

           Summary: Improve shouldThrow from js-test-pre.js
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: arv at chromium.org


Currently we do an == to compare the expected exception. It would be good if we could pass a constructor and do an instanceof check instead,

Currently:

shouldThrow('localStorage.key()', '"TypeError: Not enough arguments"')

It would be useful to allow this too

shouldThrow('localStorage.key()', 'TypeError')

which would do an instanceof check instead.

We could even go one step further and also allow checking the message of the exception:

shouldThrow('localStorage.key()', 'TypeError', '"Not enough arguments"')

The benefit is that this would work better on different browsers where the toString of the exception does not match what we do in WebKit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.