[Webkit-unassigned] [Bug 71352] [EFL] Port tiled backing store

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 2 09:56:36 PDT 2011


KwangHyuk <hyuki.kim at samsung.com> changed:

           What    |Removed                     |Added
                 CC|                            |hyuki.kim at samsung.com

--- Comment #5 from KwangHyuk <hyuki.kim at samsung.com>  2011-11-02 09:56:36 PST ---
> Source/WebKit/efl/ewk/ewk_private.h:162
> +EAPI void ewk_view_backingstore_invalidate(Evas_Object* o, const Eina_Rectangle *area);

Would you check the location of '*' for parameter area ? and I prefer ewkView instead of one character 'o'. :)
In addition, backing_store looks more natural.

> Source/WebKit/efl/ewk/ewk_private.h:163
> +EAPI void ewk_view_backingstore_adjuct_visible_rect(Evas_Object* o);

May adjuct mean adjust ? and  prefer ewkView instead of one character 'o'.
In addition, Would you check the sequence of each word for API ?

> Source/WebKit/efl/ewk/ewk_private.h:164
> +EAPI Eina_Bool ewk_view_setting_tiled_backingstore_enable_set(Evas_Object* o, Eina_Bool enable);

As ewk_private.h is for internal usage, I think that EAPI won't be required in here.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list