[Webkit-unassigned] [Bug 62108] [Qt] Failing test media/video-document-types.html

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 2 07:28:01 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=62108





--- Comment #2 from Jesus Sanchez-Palencia <jesus at webkit.org>  2011-11-02 07:28:01 PST ---
(In reply to comment #1)
> Created an attachment (id=113300)
 --> (https://bugs.webkit.org/attachment.cgi?id=113300&action=review) [details]
> patch
> 
> media/video-document-types.html (when removed from the QT skipped list) runs fine now with the latest code base.
> 
> But logically, we still need to cancel the main resource load, if the data is handled by MediaDocument.
> Webkit2 as well as all other ports (GTK/Chromium etc) do that.
> 
> In my patch I didn't un-skip the media/video-document-types.html because the media folder itself is in 
> skipped list.

LGTM. I was going to fix our WebKit1 shouldFallBack implementation, so thanks! :)

I'm not 100% sure about the commitLoad part but I did a quick check and other ports are handling it like that, as you said. Isn't there any other tests we can un-skip after this?

By the way, can't we un-skip the media folder and this test and then just skip everything else in there?

Thanks again!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list