[Webkit-unassigned] [Bug 71111] [GTK] Add webkit_settings_new_with_settings() to WebKit2 GTK+ API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71111





--- Comment #9 from Gustavo Noronha (kov) <gns at gnome.org>  2011-11-02 07:15:24 PST ---
That's true, the no-arguments new() functions are estabilished convention, and there's a case to be made that they make it more convenient. Anyway, I don't feel strongly about this, if you think it'll be convenient I'm ok with it, but maybe we should look at renaming it.

The name sounded weird to me the first time I read, it was not immediately obvious that it would take property name:value pairs. All new_with_something() functions I could find in gobject libraries take a fixed number of arguments, all vararg functions seem to be named new_full(), what do you think of following that convention?

(hrm. I found an exception: gtk_tree_view_column_new_with_attributes(), maybe new_with_values() would make it more obvious too?)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.