[Webkit-unassigned] [Bug 65522] Optimizing arithmetic composite filter to ARM-neon SIMD instruction set

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65522


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #112165|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #8 from Dirk Schulze <krit at webkit.org>  2011-11-02 06:41:08 PST ---
(From update of attachment 112165)
View in context: https://bugs.webkit.org/attachment.cgi?id=112165&action=review

LGTM. I can just trust you on the Neon code. Just some snippets.

> Source/WebCore/ChangeLog:12
> +        for all four RGBA channels in the same time.

at the same time?

> Source/WebCore/ChangeLog:13
> +

Just mention that it won't affect the general behavior and existing tests will cover the changes.

> Source/WebCore/platform/graphics/filters/FEComposite.cpp:123
> -    float scaledK4;
> -    float scaledK1;
> +    float scaledK1, scaledK4;

that is not allowed according the webkit style rules. Just leave it as it was.

> Source/WebCore/platform/graphics/filters/FEComposite.cpp:180
> +    ASSERT(!(pixelArrayLength & 0x3));

where is pixelArrayLength?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.