[Webkit-unassigned] [Bug 65542] Need support for dirname attribute

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65542





--- Comment #15 from Rakesh <rakesh.kn at motorola.com>  2011-11-02 02:38:38 PST ---
Please suggest if following code for finding directionality is correct?

if (fastHasAttribute(dirAttr)) {
    AtomicString dirAttributeValue = fastGetAttribute(dirAttr);
    if (equalIgnoringCase(dirAttributeValue, "rtl") || equalIgnoringCase(dirAttributeValue, "ltr"))
        return dirAttributeValue;             

    if (equalIgnoringCase(dirAttributeValue, "auto")) {
        bool isAuto;
        TextDirection textDirection = directionalityIfhasDirAutoAttribute(isAuto);
        return textDirection == RTL ? "rtl" : "ltr";             
    }                                   
}                      

return "ltr";

I think 'return "ltr";' should be 'return directionality() == RTL ? "rtl" : "ltr";'
but directionality() is private in HTMLElement.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.