[Webkit-unassigned] [Bug 70395] REGRESSION: rtl horizontal scrollbar / resize bug - Body shifts on resize when scrolled all the way to the left

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70395





--- Comment #18 from Tony Chang <tony at chromium.org>  2011-11-01 17:31:52 PST ---
(From update of attachment 113261)
View in context: https://bugs.webkit.org/attachment.cgi?id=113261&action=review

Just a drive by review.  I don't really understand how the various Scroll* classes fit together.

> Source/WebCore/platform/ScrollAnimator.cpp:82
>          m_currentPosX = offset.x();
>          m_currentPosY = offset.y();
>          notifyPositionChanged();

Nit: unindent

> Source/WebCore/platform/ScrollableArea.cpp:73
> +    } else
> +        m_scrollOriginChanged = false;

Is this else necessary?  If so, why don't we set m_scrollOriginChanged = false in setScrollOrigin(X|Y)?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.