[Webkit-unassigned] [Bug 66295] [Meta] Support a reftest which follows CSS test format guidelines defined by CSS working group

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 1 16:35:31 PDT 2011


--- Comment #3 from Ojan Vafai <ojan at chromium.org>  2011-11-01 16:35:31 PST ---
(In reply to comment #2)
> Hi Dirk, thank you for the comment.
> (In reply to comment #1)
> > If the reftest links are embedded in the file, presumably that means that we can't tell from the filename (and the -expected.html convention) that something is a reftest; this might complicate things a bit. We should try to figure out a way to figure out which files are reftests without having to parse *every* test file (which could be kinda slow). 
> Yeah, my initial thought is putting all CSSWG reftests to a dedicated directory, like a LayoutTests/reftests/, until we have a nice idea to solve issues caused by mixing existing LayoutTests and CSSWG reftests in the same directories. That makes things much simpler.
> As the first attempt of integrating CSSWG reftests with new-run-webkit-tests, we are going to add '--run-csswg-runtests' command line option to new-run-webkit-tests. If that is specified, all CSSWG reftests under the dedicated directory are run. Ai-san, the intern, will try to do it from the next week.

I'm OK with this solution. We also don't need to know if a test is a reftest until after we've run the test. So, if we provide the appropriate DRT hooks, it should work fine, no?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list