[Webkit-unassigned] [Bug 71329] DFG inlining breaks function.arguments

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71329





--- Comment #7 from Oliver Hunt <oliver at apple.com>  2011-11-01 15:26:02 PST ---
(From update of attachment 113232)
View in context: https://bugs.webkit.org/attachment.cgi?id=113232&action=review

>> Source/JavaScriptCore/runtime/Arguments.h:170
>> +            ASSERT(argc == numParameters + 1);
> 
> What does ASSERT compile to if building without assertions? - does it compile to a do-nothing statement, or an empty one?
> If it compiles to an empty one, this could be a bug! - I think this should be:
> 
> ASSERT(!callFrame->isInlineCallFrame() || (argc == numParameters + 1));

The ASSERT macro does the right thing -- it's do { } while(0) IIRC

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.