[Webkit-unassigned] [Bug 66650] [Qt] Flash in a QGraphicsWebView using OpenGL is slow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66650





--- Comment #17 from Christophe Oosterlynck <christophe.oosterlynck at dzine.be>  2011-11-01 07:54:49 PST ---
(In reply to comment #16)
> (In reply to comment #15)
> > (In reply to comment #13)
> > > (In reply to comment #12)
> > > > Created an attachment (id=113163)
 --> (https://bugs.webkit.org/attachment.cgi?id=113163&action=review) [details] [details] [details] [details]
> > > > Patch
> > > > 
> > > > Optimization only applies to the case when painting with OpenGL engine (not when painting with OpenGL 2 engine) + minor style fixes
> > > 
> > > Please r? if this is up for review.
> > 
> > Done. But I still don't know what you mean with "This still doesn't describe what your patch changes." on my Changelog entry. Could you be more specific on what is expected to be written in the Changelog?
> > Right now it is still: one line that summarizes the fact that my patch is an optimization fix and a couple of lines which describe the difference with what used to happen.
> 
> For example add a [Qt] prefix and shorten it a bit maybe.
> 
> One thing I haven't quite gotten yet is what in you case the difference is between a QPixmap and an X11 pixmap? Are you using the GL graphics system?
> 
> In other words: QPainter::drawPixmap should end up using TextureFromPixmap when QPainter is backed by the OpenGL paint-engine and the QPixmap is an X11 pixmap. Why exactly isn't that the case for you?

qt_gl_preferredTextureTarget() returns GL_TEXTURE_RECTANGLE_NV instead of GL_TEXTURE_2D in my case (when not using the OpenGl 2 engine but the OpenGl 1 engine). The QPainter::drawPixmap() will call QGLContextPrivate::bindTexture(const QPixmap &pixmap, GLenum target, ...), which will try to use texture_from_pixmap. But texture_from_pixmap will only be attempted if "target == GL_TEXTURE_2D", which isn't the case since target will be GL_TEXTURE_RECTANGLE_NV because of a previous call to qt_gl_preferredTextureTarget().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.