[Webkit-unassigned] [Bug 65542] Need support for dirname attribute

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65542





--- Comment #10 from Jeremy Moskovich <playmobil at google.com>  2011-11-01 03:17:15 PST ---
(From update of attachment 111386)
View in context: https://bugs.webkit.org/attachment.cgi?id=111386&action=review

disclaimer: I'm not  a WK reviewer

>>> Source/WebCore/html/HTMLTextFormControlElement.cpp:584
>>> +        dir = String("ltr");
>> 
>> I don't know this is a right code to detect direction of the value.
>> Does any WebKit RTL expert have comment on this?
> 
> Yes, RTL expert can comment on this.

Seems really wrong that you're resolving the style yourself here, then again that might be the right way of doing it.
Would  computedStyle()->direction() work?

>> LayoutTests/fast/forms/submit-form-with-dirname-attribute.html:16
>> +</form>
> 
> The test coverage is too low.  We need to test
> * <input> and <textarea>
> * The target element has no dir attribute, dir=rtl, dir=ltr, dir=invalid.
> * The target element has no dir attribute but an ancestor element has dir= attribute.
> * The target element has RTL value, and LTR value with/without dir= attribtue.

Seconded, esp. the "ancestor element with dir= attribute" case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.