[Webkit-unassigned] [Bug 70277] MoveSelectionCommand::doApply hits an assertion when dragging text without a range selection

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 1 00:04:46 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=70277





--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org>  2011-11-01 00:04:46 PST ---
(In reply to comment #5)
> > > LayoutTests/fast/events/drag-link.html:34
> > > +
> > > +    document.getElementById("result").innerHTML = "PASS";
> > 
> > This test always passes?
> This test results into an assert if the patch is not applied, and if the drag-drop fails the 'Test link' will not be added into the actual result. Thus I think the result div is redundant and can be removed.

Given that the assertion failure never hits on release builds, you probably want to clarify that the test passes only if it does not hit assertions.

> Also, I believe this will fix bug 61008 as well.

That's nice to know. Ideally we can add a test for the bug 61008 after this patch was landed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list